Fix required option in INJECT_* type form fields #852
Closed
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code will avoid saving the 'required' option as 'true', thereby avoiding the error message in the frontend saying, 'you need to fill out every required field'.
|
This likely the wrong solution to the problem at hand, sadly I could not come up with a better one yet, as I do not fully understand the dataflow between an Any and every suggestion or critisim is more than welcome! |
This is a fix for already existing forms, which haven't been updated yet.
When editing an already existing form, this should also fix the 'required' option, on any already existing 'INJECT_' type fields.
Isti01
requested changes
Jan 25, 2025
| @@ -27,6 +27,9 @@ export const AutoFormField = ({ fieldProps, control, disabled, submittedValue }: | |||
| else defaultValue = '' | |||
| } | |||
|
|
|||
| if (fieldProps.type.startsWith('INJECT_')) | |||
| fieldProps.required = false | |||
There was a problem hiding this comment.
Don't mutate prop values in rendering code, introduce a new variable instead
There was a problem hiding this comment.
Hopefully fixed the issue!
Please check and advise
Hopefully resolves the following request by @Isti01: 'Don't mutate prop values in rendering code, introduce a new variable instead'
TGyAkos
force-pushed
the
feature/746-fix-form-inject-field
branch
from
243ea45 to
14f290b
Compare
|
Already part of staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code will avoid saving the 'required' option as 'true', thereby avoiding the error message in the frontend saying, 'you need to fill out every required field'.