Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude android unit tests from being published to npm #793

Merged

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Jan 31, 2025

📜 Description

Exclude tests folder on android on npm.

💡 Motivation and Context

The original size of this folder is about ~7kb and may be bigger in the future:

image

But in a reality those files are not used when devs add the package to their projects. So for sake of the optimization let's exclude those files from publishing to npm 🤞

📢 Changelog

JS

  • exclude android/src/test path;

🤔 How Has This Been Tested?

There is no way to test that everything will work, but size-diff shows that folder was excluded (because size has been decreased).

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added the 🤖 android Android specific label Jan 31, 2025
@kirillzyusko kirillzyusko self-assigned this Jan 31, 2025
@kirillzyusko kirillzyusko marked this pull request as draft January 31, 2025 14:08
Copy link
Contributor

📊 Package size report

Current size Target Size Difference
167666 bytes 168889 bytes -1223 bytes 📉

@kirillzyusko kirillzyusko added the 🚀 optimization You optimize something and it becomes working faster label Jan 31, 2025
@kirillzyusko kirillzyusko marked this pull request as ready for review January 31, 2025 15:03
@kirillzyusko kirillzyusko merged commit 50d630c into main Jan 31, 2025
12 checks passed
@kirillzyusko kirillzyusko deleted the fix/exclude-unit-tests-from-being-published-to-npm branch January 31, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 🚀 optimization You optimize something and it becomes working faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant