fix: exclude StatusBar
height from useWindowDimensions
if StatusBar
is not translucent
#837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Exclude
StatusBar
height fromuseWindowDimensions
if StatusBar is not translucent.💡 Motivation and Context
In #468 I added own implementation of
useWindowDimensions
I mentioned this:
And as you can see returned values do not match values returned by
useSafeAreaInsets
. Turns out they should match each other to make components likeKeyboardAvoidingView
to work properly.So in this PR I'm excluding the
marginTop
to matchuseSafeAreaInsets
behavior.Closes #833
Reproduction code:
📢 Changelog
Android
marginTop
fromuseWindowDimensions
;🤔 How Has This Been Tested?
Tested on Pixel 7 Pro with Android 15.
📸 Screenshots (if appropriate):
statusBarTranslucent={false}
telegram-cloud-document-2-5330396151998868945.mp4
telegram-cloud-document-2-5330396151998868977.mp4
statusBarTranslucent={true}
telegram-cloud-document-2-5330396151998868968.mp4
telegram-cloud-document-2-5330396151998868974.mp4
📝 Checklist