Mixing fixes #1
Open
Mixing fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing bug: When a broadcast is send before the locktime is done, the proof will break.
work with the demonstrator.
…ixing and restarting ptp/bitnym multiple times
- add mixAborted listener to notify gui if mixing has failed - fix problem when broadcasts are received simultaneously on each side - GUI shows correct pseudonym after mixing
- add timeout for sending broadcast - add mixing started event listener - catch more errors and abort mixing
- add own class for mix request messages
…avoid bitcoinj warning
- send ptp data with message object - add random time before sending broadcast - add mixAbortMessage
- make name changes of peer on new pseudonym creation visible in gui - fix compile error (TransactionGenerator)
- fix some mixing aborts caused by invalid partner proof - fix invalid pseudonyms after mixing - add more information on gui
sfriebe
commented
Dec 17, 2018
| @@ -87,7 +87,7 @@ public BitNymWallet() { | |||
| //MainClass.params = TestNet3Params.get(); | |||
| MainClass.params = RegTestParams.get(); | |||
| params = MainClass.params; | |||
| // TODO(PM) use context as parameter at certain methods to avoid bitcoin warinings | |||
| // TODO(PM) use context as parameter at certain methods to avoid bitcoinj warnings | |||
There was a problem hiding this comment.
Is this still a todo or is this done now?
There was a problem hiding this comment.
Still todo, but not really important
| @@ -831,4 +850,13 @@ public Identifier getIdentifier() { | |||
| } | |||
| } | |||
|
|
|||
| public void sendMessage(Object message, Identifier ident) { | |||
| try { | |||
| ptp.sendMessage(message, ident); | |||
There was a problem hiding this comment.
Make this.ptp private? Not sure whether this is possible.
There was a problem hiding this comment.
Maybe possible but not so trivial
sfriebe
commented
Dec 17, 2018
# Conflicts: # src/bitnymWallet/ChallengeResponseVerifier.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.