Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use special property revision to set the version only once" #6156

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

henning-gerhardt
Copy link
Collaborator

@henning-gerhardt henning-gerhardt commented Jul 30, 2024

Reverts #6127

Fixes #6153

As this pull request creates POM files for every module and the whole project with wrong artifact version information.

With this wrong artifact version information $revision which can not be resolved inside the project by Maven itself and even not if you want to re-use a Kitodo.Production module in an other context (maybe currently only a future view) or want to develop an extended module which is basing on an existing Kitodo.Production module (which may already happen).

The issue is, that $revision is set as a placeholder inside the needed artifact but is read by maven not as a placeholder but as as string value. This is mismatching while resolving the artifact version.

Using the revision as a special property may not be bad but is current usage is wrong or at least not right. Until this is fixed the changes should be reverted and should be re-applied after this issue itself is fixed.

@stweil
Copy link
Member

stweil commented Jul 30, 2024

This revert is no longer needed with commit de21644. The commit adds the flatten-maven-plugin which is required for multi-modules projects like Kitodo.Production (see documentation). It was missing up to now and will be added by PR #6133.

@stweil
Copy link
Member

stweil commented Jul 30, 2024

@henning-gerhardt, it is sufficient to apply the commit de21644 to Git master to fix your workflow again. Should I create a PR which only includes this fix? Maybe it can then be applied faster than PR #6133.

@henning-gerhardt
Copy link
Collaborator Author

The right way is - at least for me - to revert this changes and not stay with this changes and add more software and complex configuration including a higher level of software and maintenance complexity on top to get this everything running again.

As discovered by @stweil himself running mvn commands on module level are broken too which I not discovered myself but used already in the past many times. One reason more to revert this changes.

@solth solth merged commit 4dcf945 into kitodo:master Aug 2, 2024
5 checks passed
@henning-gerhardt henning-gerhardt deleted the revert-6127-revision branch August 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not run maven flyway in Kitodo-DataManagement module
3 participants