Flake8 CI fixes (#451)

* Pep8 fixes

* tox Pep8 compliance

* Excluded external tools folder from flake 8 tests

* Added Flake 8 exclusions

* Pep8 fixes

* Pep8 fixes

* Corrected type

* Pep8 fixes

* Pep 8 compliance

* Pep8 fixes

* Pep8  fixes

* Pep8 fixes

* Pep8 fixes

* Pep 8 fixes

* Pep 8 fixes

* Pep8 fixes

* Pep8 fixes

* Pep8 fixes

* Pep8

* Pep8

* Pep 8

* Pep 8

* Pep8 fixes

* Pep8

* Pep8

* Pep8

* Pep8 fixes

* Pep8 fixes

* Pep8 fixes

* Pep8 fixes

* Pep8 fixes

* Revert chagnes

* Revert changes to kivy/__init.py

* Revert changes

* REvert changes

* Revert changes

* Revert changes to toolchain

* Add files exclusions to tox.ini

* Added exclusions for alias recipes

* Remove dead code

* Added py extension to recipes

* Removed recipe build skip

* Improves recipe matching

Previous expression was matching all the following three lines of a `git diff --name-only` output.
```
recipes/hostlibffi/__init__.py
recipes/hostpython.py
recipes/hostpython2/__init__.py
```
This was resulting to a bug when later splitting with `recipe = file_path.split('/')[1]` the `recipes/hostpython.py` string would return including the `\n` new line char, see:
 ```
>>> 'recipes/hostpython.py\n'.split('/')[1]
'hostpython.py\n'
>>> 'recipes/hostlibffi/__init__.py\n'.split('/')[1]
'hostlibffi'
>>> 
```

Co-authored-by: Andre Miras <[email protected]>

.ci/rebuild_updated_recipes.py

@@ -1,6 +1,7 @@
 import sh
-import shutil
 import subprocess
+from fnmatch import fnmatch
+
 
 def modified_recipes(branch='origin/master'):
     """
@@ -14,14 +15,15 @@ def modified_recipes(branch='origin/master'):
     git_diff = sh.contrib.git.diff('--name-only', branch)
     recipes = set()
     for file_path in git_diff:
-        if 'recipes/' in file_path:
+        if fnmatch(file_path, "recipes/*/__init__.py\n"):
             recipe = file_path.split('/')[1]
             recipes.add(recipe)
     return recipes
 
+
 if __name__ == "__main__":
     updated_recipes = " ".join(modified_recipes())
     if updated_recipes != '':
         subprocess.run(f"python3 toolchain.py build {updated_recipes}", shell=True, check=True)
     else:
-        print("Nothing to do. No updated recipes.")
+        print("Nothing to do. No updated recipes.")

recipes/audiostream/__init__.py

@@ -10,4 +10,3 @@ class AudiostreamRecipe(CythonRecipe):
 
 
 recipe = AudiostreamRecipe()
-

recipes/click/__init__.py

@@ -1,13 +1,15 @@
 # pure-python package, this can be removed when we'll support any python package
 from toolchain import PythonRecipe, shprint
 from os.path import join
-import sh, os
+import sh
+import os
+
 
 class ClickRecipe(PythonRecipe):
     version = "master"
     url = "https://github.com/mitsuhiko/click/archive/{version}.zip"
     depends = ["python"]
-    
+
     def install(self):
         arch = list(self.filtered_archs)[0]
         build_dir = self.get_build_dir(arch.arch)
@@ -20,5 +22,5 @@ def install(self):
         shprint(cmd, "-i", "", "s/setuptools/distutils.core/g", "./setup.py", _env=build_env)
         shprint(hostpython, "setup.py", "install", "--prefix", dest_dir, _env=build_env)
 
-recipe = ClickRecipe()
 
+recipe = ClickRecipe()

recipes/curly/__init__.py

@@ -1,5 +1,6 @@
 from toolchain import CythonRecipe
 
+
 class CurlyRecipe(CythonRecipe):
     version = "master"
     url = "https://github.com/tito/curly/archive/{version}.zip"

recipes/cymunk/__init__.py

@@ -3,10 +3,7 @@
 E-mail: [email protected], [email protected]
 """
 
-from toolchain import CythonRecipe,shprint
-import os
-from os.path import join
-import sh
+from toolchain import CythonRecipe
 
 
 class CymunkRecipe(CythonRecipe):

recipes/distribute/__init__.py

@@ -1,6 +1,8 @@
 from toolchain import PythonRecipe, shprint
 from os.path import join
-import sh, os
+import sh
+import os
+
 
 class DistributeRecipe(PythonRecipe):
     version = "0.7.3"
@@ -18,4 +20,5 @@ def install(self):
         build_env['PYTHONPATH'] = join(dest_dir, 'lib', 'python2.7', 'site-packages')
         shprint(hostpython, "setup.py", "install", "--prefix", dest_dir, _env=build_env)
 
+
 recipe = DistributeRecipe()

recipes/ffmpeg/__init__.py

@@ -1,5 +1,5 @@
 from toolchain import Recipe, shprint
-from os.path import join, exists
+from os.path import join
 import sh
 
 

recipes/ffpyplayer/__init__.py

@@ -1,6 +1,5 @@
-from toolchain import CythonRecipe, shprint
+from toolchain import CythonRecipe
 from os.path import join
-import sh
 
 
 class FFPyplayerRecipe(CythonRecipe):
@@ -19,19 +18,18 @@ def get_recipe_env(self, arch):
         env["CC"] += " -I{}".format(
             join(self.ctx.dist_dir, "include", arch.arch, "libffi"))
         env["SDL_INCLUDE_DIR"] = join(self.ctx.dist_dir, "include",
-            "common", "sdl2")
+                                      "common", "sdl2")
         env["FFMPEG_INCLUDE_DIR"] = join(self.ctx.dist_dir, "include",
-            arch.arch, "ffmpeg")
+                                         arch.arch, "ffmpeg")
         env["CONFIG_POSTPROC"] = "0"
         return env
 
     def prebuild_arch(self, arch):
         # common to all archs
-        if  self.has_marker("patched"):
+        if self.has_marker("patched"):
             return
         self.apply_patch("misc-visibility.patch")
         self.set_marker("patched")
 
 
 recipe = FFPyplayerRecipe()
-

recipes/flask/__init__.py

@@ -1,13 +1,15 @@
 # pure-python package, this can be removed when we'll support any python package
 from toolchain import PythonRecipe, shprint
 from os.path import join
-import sh, os
+import sh
+import os
+
 
 class FlaskRecipe(PythonRecipe):
     version = "master"
     url = "https://github.com/mitsuhiko/flask/archive/{version}.zip"
-    depends = ["python","jinja2","werkzeug","itsdangerous","click"]
-    
+    depends = ["python", "jinja2", "werkzeug", "itsdangerous", "click"]
+
     def install(self):
         arch = list(self.filtered_archs)[0]
         build_dir = self.get_build_dir(arch.arch)
@@ -20,5 +22,5 @@ def install(self):
         shprint(cmd, "-i", "", "s/setuptools/distutils.core/g", "./setup.py", _env=build_env)
         shprint(hostpython, "setup.py", "install", "--prefix", dest_dir, _env=build_env)
 
-recipe = FlaskRecipe()
 
+recipe = FlaskRecipe()

recipes/freetype/__init__.py

@@ -32,4 +32,3 @@ def build_arch(self, arch):
 
 
 recipe = FreetypeRecipe()
-

recipes/host_setuptools/__init__.py

@@ -1,8 +1,7 @@
 from toolchain import Recipe, shprint
-from os.path import join, exists
+from os.path import join
 import sh
 import os
-import fnmatch
 import shutil
 
 
@@ -13,7 +12,7 @@ class HostSetuptools(Recipe):
 
     def prebuild_arch(self, arch):
         hostpython = sh.Command(self.ctx.hostpython)
-        sh.curl("-O",  "https://bootstrap.pypa.io/ez_setup.py")
+        sh.curl("-O", "https://bootstrap.pypa.io/ez_setup.py")
         shprint(hostpython, "./ez_setup.py")
         # Extract setuptools egg and remove .pth files. Otherwise subsequent
         # python package installations using setuptools will raise exceptions.
@@ -31,4 +30,5 @@ def prebuild_arch(self, arch):
         os.remove('easy-install.pth')
         shutil.rmtree('EGG-INFO')
 
+
 recipe = HostSetuptools()

recipes/hostlibffi/__init__.py

@@ -5,6 +5,7 @@
 
 logger = logging.getLogger(__name__)
 
+
 class LibffiRecipe(Recipe):
     version = "3.2.1"
     url = "ftp://sourceware.org/pub/libffi/libffi-{version}.tar.gz"
@@ -29,7 +30,7 @@ def prebuild_arch(self, arch):
             return
         # necessary as it doesn't compile with XCode 6.0. If we use 5.1.1, the
         # compiler for i386 is not working.
-        #shprint(sh.sed,
+        # shprint(sh.sed,
         #        "-i.bak",
         #        "s/-miphoneos-version-min=5.1.1/-miphoneos-version-min=6.0/g",
         #        "generate-darwin-source-and-headers.py")
@@ -63,4 +64,5 @@ def build_arch(self, arch):
     def postbuild_arch(self, arch):
         pass
 
+
 recipe = LibffiRecipe()

recipes/hostpython.py

@@ -5,6 +5,7 @@
 
 logger = logging.getLogger(__name__)
 
+
 class HostpythonAliasRecipe(Recipe):
     is_alias = True
 
@@ -24,4 +25,5 @@ def init_after_import(self, ctx):
         if hostpython:
             self.depends = [hostpython]
 
+
 recipe = HostpythonAliasRecipe()

recipes/hostpython2/_scproxy.py

@@ -3,8 +3,10 @@
 No proxy is supported yet.
 '''
 
+
 def _get_proxy_settings():
     return {'exclude_simple': 1}
 
+
 def _get_proxies():
     return {}

recipes/ios/src/setup.py

@@ -1,14 +1,14 @@
 from distutils.core import setup, Extension
-import os
+
 
 setup(name='ios',
       version='1.1',
       ext_modules=[
-        Extension(
-            'ios', ['ios.c', 'ios_utils.m', 'ios_mail.m', 'ios_browser.m',
-                    'ios_filechooser.m'],
-            libraries=[ ],
-            library_dirs=[],
-            )
-        ]
+          Extension('ios',
+                    ['ios.c', 'ios_utils.m', 'ios_mail.m', 'ios_browser.m',
+                     'ios_filechooser.m'],
+                    libraries=[],
+                    library_dirs=[],
+                    )
+                  ]
       )

recipes/itsdangerous/__init__.py

@@ -1,7 +1,9 @@
 # pure-python package, this can be removed when we'll support any python package
 from toolchain import PythonRecipe, shprint
 from os.path import join
-import sh, os
+import sh
+import os
+
 
 class ItsDangerousRecipe(PythonRecipe):
     version = "master"
@@ -20,5 +22,5 @@ def install(self):
         shprint(cmd, "-i", "", "s/setuptools/distutils.core/g", "./setup.py", _env=build_env)
         shprint(hostpython, "setup.py", "install", "--prefix", dest_dir, _env=build_env)
 
-recipe = ItsDangerousRecipe()
 
+recipe = ItsDangerousRecipe()

recipes/jinja2/__init__.py

@@ -1,12 +1,14 @@
 # pure-python package, this can be removed when we'll support any python package
 from toolchain import PythonRecipe, shprint
 from os.path import join
-import sh, os
+import sh
+import os
+
 
 class Jinja2Recipe(PythonRecipe):
     version = "master"
     url = "https://github.com/mitsuhiko/jinja2/archive/{version}.zip"
-    depends = ["python","markupsafe"]
+    depends = ["python", "markupsafe"]
 
     def install(self):
         arch = list(self.filtered_archs)[0]
@@ -20,5 +22,5 @@ def install(self):
         shprint(cmd, "-i", "", "s/setuptools/distutils.core/g", "./setup.py", _env=build_env)
         shprint(hostpython, "setup.py", "install", "--prefix", dest_dir, _env=build_env)
 
-recipe = Jinja2Recipe()
 
+recipe = Jinja2Recipe()