Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed outdated text showing when a zim file could not open. #3887

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Jun 20, 2024

Fixes #3884

Outdated text was showing when a zim file could not open in the Kiwix, this text was for the older UI, and now we have removed the "Device Tab" from the "Library" screen so this text is outdated and misleading the users. so we have changed this text according to the new UI.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Outdated text was showing when a zim file could not open in the kiwix, this text was for the older UI, and now we have removed the "Device Tab" from the "Library" screen so this text is outdated and misleading the users. so we have changed this text according to the new UI.
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.52%. Comparing base (99fe898) to head (a1f33ca).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3887      +/-   ##
============================================
- Coverage     53.58%   53.52%   -0.07%     
+ Complexity     1400     1396       -4     
============================================
  Files           302      302              
  Lines         11588    11588              
  Branches       1527     1527              
============================================
- Hits           6210     6203       -7     
- Misses         4380     4383       +3     
- Partials        998     1002       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 4a6fecd into main Jun 20, 2024
10 checks passed
@kelson42 kelson42 deleted the Fixes#3884 branch June 20, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kiwix-3.11.0] Zim files are not opening with kiwix when clicking from the storage.
3 participants