-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes kiwix-android issue#765 #289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 11.59% 11.59%
=======================================
Files 43 43
Lines 3371 3371
Branches 1764 1764
=======================================
Hits 391 391
Misses 2817 2817
Partials 163 163 Continue to review full report at Codecov.
|
This branch needs to be rebased |
@kelson42 I had merged with master yesterday before pushing |
@Aditya-Sood Yes, the rules are not the same as on kiwix-android. Here the feature branches need to be rebased properly on master before review/merge. So never ever a merge from master in a feature branch on this repo... and in general in all repos (except kiwix-android). |
02d1ab0
to
2af9ba4
Compare
@kelson42 I've re-based the branch |
@kelson42 what is the expected date of the next kiwix-lib version release? I'll set a reminder for updating the complimentary kiwix-android PR accordingly |
Contains changes to JNIKiwixReader for kiwix-android which fix issue #765
Since kiwix-build relies on using the master branch of the kiwix-lib source code, the PR for updated code of kiwix-android needs to use the same version of kiwix-lib as the one which has this PR merged