Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to faster pymatgen #163

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

ltalirz
Copy link
Contributor

@ltalirz ltalirz commented Sep 6, 2021

Graph generation is sped up by orders of magnitude.

Test suite runtime goes down to ~1 minute on CI (30s on my macbook).

  • Breaking change (fix or feature that would cause existing functionality to change)

@ltalirz ltalirz marked this pull request as draft September 6, 2021 15:22
@ltalirz
Copy link
Contributor Author

ltalirz commented Sep 6, 2021

Example: str_m1_o12004_LTF.cif 4860 atoms

new

 In [1]: from mofchecker import MOFChecker

In [2]: %timeit -r1 -n1 mofchecker = MOFChecker.from
   ...: _cif('tests/structures/str_m1_o12004_LTF.cif
   ...: ')
12.2 s ± 0 ns per loop (mean ± std. dev. of 1 run, 1 loop each)

Note: 9s of these 12s are spent on parsing the CIF

old

In [2]: %timeit -r1 -n1 mofchecker = MOFChecker.from
   ...: _cif('tests/structures/str_m1_o12004_LTF.cif
   ...: ')
11min 25s ± 0 ns per loop (mean ± std. dev. of 1 run, 1 loop each)

@ltalirz
Copy link
Contributor Author

ltalirz commented Sep 10, 2021

To update for next release after pymatgen v2022.0.14

https://github.com/materialsproject/pymatgen

@kjappelbaum
Copy link
Owner

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #163 (c409a51) into master (ddd5b4a) will not change coverage.
The diff coverage is n/a.

@ltalirz ltalirz marked this pull request as ready for review October 21, 2021 21:55
@ltalirz
Copy link
Contributor Author

ltalirz commented Oct 21, 2021

Nice, let's get this out

@kjappelbaum
Copy link
Owner

kjappelbaum commented Oct 21, 2021

hm, yes. The CI failure with AttributeError: module 'pyeqeq_eqeq' has no attribute 'ostream_redirect' on macOS seems to be due to our EqEq package

lsmo-epfl/EQeq#19

@kjappelbaum kjappelbaum changed the title switch to faster pymatgen chore: switch to faster pymatgen Oct 21, 2021
@kjappelbaum kjappelbaum merged commit b39ce01 into kjappelbaum:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants