Fixed computation of loginChangeable

Fixes #55
kkapsner · Jan 29, 2022 · e2bff42 · e2bff42
1 parent f4fdc22
commit e2bff42
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 20 deletions.
diff --git a/experiment/implementation.js b/experiment/implementation.js
@@ -448,23 +448,19 @@ function getCredentialInfo(window){
 		return false;
 	}
 
-	function loginChangeable(login){
+	const promptData = currentPromptData || getCredentialInfoFromStrings(window.args.title, window.args.text);
+	if (promptData){
+		const host = promptData.host;
+		let login = promptData.login;
+		let loginChangeable = false;
 		if (!login && promptType === "promptUserAndPass"){
 			const loginInput = window.document.getElementById("loginTextbox");
 			if (loginInput && loginInput.value){
 				login = loginInput.value;
-				return true;
 			}
+			loginChangeable = true;
 		}
-		return false;
-	}
-	const promptData = currentPromptData || getCredentialInfoFromStrings(window.args.title, window.args.text);
-	if (promptData){
-		return {
-			host: promptData.host,
-			login: promptData.login,
-			loginChangeable: loginChangeable(promptData.login),
-		};
+		return {host, login, loginChangeable};
 	}
 	return false;
 }

diff --git a/releaseNotes.txt b/releaseNotes.txt
@@ -1,16 +1,8 @@
 Version 0.1.12
 
-new features:
-
-	- 
-
-changes:
-
-	- 
-
 fixes:
 
-	- 
+	- password prompts without a given username did not find any password in newer Thunderbird version
 
 Version 0.1.11
 

diff --git a/versions/updates.json b/versions/updates.json
@@ -49,6 +49,10 @@
 				{
 					"version": "0.1.11",
 					"update_link": "https://keepassxc-mail.kkapsner.de/versions/keepassxc-mail-0.1.11.xpi"
+				},
+				{
+					"version": "0.1.12",
+					"update_link": "https://keepassxc-mail.kkapsner.de/versions/keepassxc-mail-0.1.12.xpi"
 				}
 			]
 		}