connectedhomeip: lock: added erasing Thread configuration on boot #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently CHIP does not fully support saving data in the persistent storage, so saving only part of it (Thread configuration) might be confusing. Added erasing Thread configuration on init then. * Added setting Thread device type to MED. Signed-off-by: Kamil Kasperczyk <[email protected]>
LuDuda
approved these changes
Feb 4, 2021
| /* Until all CHIP data needed to perform full communication are not saved in the persistent storage, | ||
| * Thread configuration should not be saved either. | ||
| * TODO: Remove it after having full support for persistent storage in CHIP */ | ||
| if(otDatasetIsCommissioned(openthread_get_default_instance())) { |
There was a problem hiding this comment.
Suggested change
| if(otDatasetIsCommissioned(openthread_get_default_instance())) { | |
| if (otDatasetIsCommissioned(openthread_get_default_instance())) { |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
kkasperczyk-no
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Include HOSTAP_BASE to fix header file paths * Select WEP automatically through Kconfig Signed-off-by: Chaitanya Tata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the persistent storage, so saving only part of it (Thread
configuration) might be confusing. Added erasing Thread
configuration on init then.
Signed-off-by: Kamil Kasperczyk [email protected]