Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate lists for newsletter setup #279

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

smoucka
Copy link
Contributor

@smoucka smoucka commented Dec 11, 2023

Description

V3 lists api only returns 10 lists per page. In order to fully populate the Newsletter configuration dropdown menu we need to paginate to fetch all lists for an account.

Manual Testing Steps

  1. local setup, tested with an account with 155 lists and with an account with 4 lists. 155 had a few seconds of latency due to the synchronous requests

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@smoucka smoucka requested a review from a team as a code owner December 11, 2023 15:56
@smoucka smoucka requested a review from cykolln December 11, 2023 15:58
@@ -187,7 +187,7 @@ fabric.properties

.idea/*

!.idea/codeStyles
#!.idea/codeStyles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing this from the .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'm not sure why that was excluded. The .idea directory is phpstorm related. I ended up with a codeStyles config file that was committed so making sure we don't get those in here by accident.

@smoucka smoucka merged commit 501ba91 into master Dec 12, 2023
3 checks passed
@smoucka smoucka deleted the 202312_swm_BUGPORT-419_paginate_get_lists branch December 12, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants