Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add more macOS runners #1317

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

rockstorm101
Copy link
Collaborator

No description provided.

@rockstorm101
Copy link
Collaborator Author

Dear @dubninja, would you please be so kind to try out the macOS 12 binary produced by this PR and check if it works as expected?

@a2k-hanlon, could you please once more test whether the binary for macOS 10.15 works OK now?

@a2k-hanlon
Copy link
Collaborator

Yes, this 10.15 binary does run successfully on my 10.15.7 machine.

@rockstorm101
Copy link
Collaborator Author

I managed to run the binary on an Intel MacBook with macOS 11.6. So I guess that one works as well.

However I tried running the macOS 12 binary on an M1 iMac with macOS 13.2 and it wouldn't start. As expected I guess?

@a2k-hanlon
Copy link
Collaborator

a2k-hanlon commented Feb 18, 2023 via email

@rockstorm101
Copy link
Collaborator Author

Hi all, I'm still unable to test the suggested trick. I'm thinking of giving this PR until the end of this month. If by then we haven't managed to test the macOS 12 binary then:

  • A) Drop the binary for macOS 12, and only provide those for versions 10 and 11
  • B) Provide the three of them, chances are the one for macOS 12 works just as well as the other two
  • C) Keep waiting and put the next release on hold
  • D) None of the above

Thoughts?

@DivingDuck
Copy link
Collaborator

I just took a look on the log files:
There are two entries, the first "pip install --use-pep517". I recognize this in my repository as well. It looks like we should change this in future and add --use-pep517 as mentioned. But for now not the problem.

The second one seems to be a problem - at least it do not happen with the two other runners for macOS:
build (macos-12, x64, 3.10), "Build Cython ext" line 16 ff. There is an error building the gcoder_line extension.

For the question:
Solution A seems to be a good compromise.
The interim version for macOS12 is still available for those who want to help and test.

@rockstorm101
Copy link
Collaborator Author

the first "pip install --use-pep517". I recognize this in my repository as well. It looks like we should change this in future and add --use-pep517 as mentioned.

I don't fully understand what is going on in there. I can see the deprecation warning in the logs but, is it a problem with cairocffi not following the standard practices? Is it because the wheel package is not installed? Or do we really need to enforce legacy install method? Anyway, good catch! I've created #1318 to discuss this at a later point.

at least it do not happen with the two other runners for macOS:
build (macos-12, x64, 3.10), "Build Cython ext" line 16 ff. There is an error building the gcoder_line extension.

I don't see a true error there, aren't they just warnings? Interestingly, on the build for 12 the generated binary has "11.7" on its path. The one for 11 has "11.7" as well (that's fine) and the one for 10 has "10.15" (as expected).

@rockstorm101
Copy link
Collaborator Author

As per this comment, the binaries produced by this change were tested with satisfactory (enough) results. So I'm merging this PR.

@rockstorm101 rockstorm101 merged commit fbe661e into kliment:master Mar 8, 2023
@rockstorm101 rockstorm101 deleted the pr-macos-archs branch March 15, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants