Add fix for JUCE compilation on modern GCC, add warning about linking for Jack on distributions using Pipewire to Makefile.linux #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote to Makefile.linux warning about linking to Pipewire libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of GCC complain about a bad cast in the code of the JUCE library; adding the 'unsigned' keyword makes these errors go away and allows for clean compilation.
Modern distributions have now begun shipping Pipewire as a full JACK replacement, and in some cases the linker is unable to find the jack libraries provided by Pipewire. This is probably pretty distro-dependent, so I added a warning to the Linux Makefile to at least inform users that they may need to manually add library folders to PLATFORM_LDFLAGS during the compilation phase.