Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple SMTP servers #2290

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Multiple SMTP servers #2290

merged 7 commits into from
Feb 11, 2025

Conversation

lcd1232
Copy link
Contributor

@lcd1232 lcd1232 commented Feb 4, 2025 •
edited
Loading

  • Allows to choose SMTP server per campaign
  • Adds ability to name your SMTP server

Closes #1703

Screenshots

image image

@knadh
Copy link
Owner

knadh commented Feb 5, 2025

Thanks @lcd1232. This is nice. I'll review and test this in the next couple of weeks and consider it for the upcoming release. This has been a long pending request from many users.

@knadh knadh self-assigned this Feb 5, 2025
@knadh
Refactor and simplify SMTP-messenger logic.
f6c6588 
- Make email messenger accept a name and remove any logic from within it.
- Refactor SMTP and and messenger init for consistency.
- Refactor app.messengers to be a slice[] and not map to remove superfluous
  sorting logic.
- Refactor SMTP settings and move the new name field to the bottom to not
  break familiarity.
- Refactor campaign form to print email messengers as a sub <optgroup> of the
  main messenger.
- Init all individual e-mail messengers as `email / $name`.
- Remove unrelated compose file.
@knadh
Copy link
Owner

knadh commented Feb 10, 2025

@lcd1232, I've added a few changes to the PR: f6c6588

Please take a look. I think this is good to be merged now.

lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
cmd/init.go Show resolved Hide resolved
lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
cmd/init.go Show resolved Hide resolved
lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
i18n/en.json Outdated Show resolved Hide resolved
@lcd1232
Copy link
Contributor Author

lcd1232 commented Feb 10, 2025

@knadh added some comments. Other than that it looks good

@knadh knadh merged commit d055cc5 into knadh:master Feb 11, 2025
@knadh knadh mentioned this pull request Feb 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knadh knadh knadh left review comments

Assignees

@knadh knadh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pick an SMTP server per campaign
2 participants
@lcd1232 @knadh