Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a compiler warning. #1044

Closed
wants to merge 1 commit into from
Closed

Fixed a compiler warning. #1044

wants to merge 1 commit into from

Conversation

jstbyte
Copy link

@jstbyte jstbyte commented Mar 5, 2024

Fixed a compiler warning caused by compering unsigned int with signed int.

Fixed a compiler warning caused by compering unsigned int with signed int.
@hmueller01
Copy link

This is duplicate to #1031 ...

@jstbyte jstbyte closed this by deleting the head repository Mar 8, 2024
@hmueller01
Copy link

Too bad that @knolleary doesn't maintain this any more. I was hoping the guy's from @thingsboard will do. But they actually don't.

@knolleary
Copy link
Owner

@hmueller01 I'm sorry this has fallen off my radar. I don't actively use it these days, which makes testing and verifying changes tricky.

That said, I'm sure there must be a set of minimal changes just waiting to be sorted - they just need picking out of the backlog of PRs.

If you had any suggestions for what should be prioritised, I'd happily take the input and try to get a new release done with them in next week.

I will then see what I can do to make it clearer in this repo what level of support/help I'm able to provide.

@hmueller01
Copy link

@knolleary Nice hearing from you! I‘ll take a look into this tonight and drop a comment on the relevant PRs.

@hmueller01
Copy link

PS: I can do the testing on ESP8266. I don't have an ESP32 or other boards. So this must be done by someone else.

@knolleary
Copy link
Owner

@hmueller01 I've opened #1045 to pull together a plan of what needs to happen in the short term. If you can comment on there with any PRs you think need looking at, that would be super helpful.

@bartex
Copy link

bartex commented Mar 12, 2024

Once the new release is out, we can test it on ESP32-S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants