Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup/kithcen] Change description with using notify-recognition #343

Merged

Conversation

tkmtnt7000
Copy link

This PR catches up jsk-ros-pkg#1568 and adds missing commit.

When navigation stuck, the message like '迷子になっちゃった' is sent.
When Fetch found some objects in kitchen, it notifies.

@knorth55 knorth55 merged commit af7275b into knorth55:fetch15 Sep 8, 2022
@tkmtnt7000 tkmtnt7000 deleted the PR-update-smach-description-fetch15 branch September 9, 2022 12:45
@nakane11
Copy link

I'm not sure where to write this, but isn't it necessary to delete description and image from userdata in jsk-ros-pkg@5409e00 ?

@tkmtnt7000
Copy link
Author

@nakane11
Thank you for catching.
I know that we have to delete them carefully from userdata like following when we don't want to show its messages.

...
(set-alist 'description "" userdata)
(set-alist 'image "" userdata)
...

This is the part that I was a little lazy to do.
Anyway, I'll fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants