Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cope with breaking changes in pyxform 3.0.0 #331

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

jnm
Copy link
Member

@jnm jnm commented Jan 21, 2025

Beginning with XLSForm/pyxform#740, SurveyElement inherits from Mapping instead of dict, and therefore has no update() method.

Make sure you pip install pyxform==3.0.0 before running pytest to verify that you're testing against the new version of pyxform!

See XLSForm/pyxform@6918b40

@coveralls
Copy link

coveralls commented Jan 21, 2025

Coverage Status

coverage: 86.674% (+0.005%) from 86.669%
when pulling af724a2 on pyxform-3.0.0-compatibility
into 894d285 on main.

@jnm jnm changed the title Cope with breaking changes in pyxform 3.3.0 Cope with breaking changes in pyxform 3.0.0 Jan 22, 2025
Beginning with XLSForm/pyxform#740, `SurveyElement` inherits from
`Mapping` instead of `dict`, and therefore has no `update()` method.

See XLSForm/pyxform@6918b40
@jnm jnm force-pushed the pyxform-3.0.0-compatibility branch from 66cc3bf to af724a2 Compare January 22, 2025 14:23
@jnm jnm merged commit cc9aaf6 into main Jan 22, 2025
3 checks passed
@jnm jnm deleted the pyxform-3.0.0-compatibility branch January 22, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants