Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(submissions)!: add submission unique identifier (meta/rootUuid) in data API response TASK-1458 #5435

Merged

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Jan 21, 2025

📣 Summary

Added the unique identifier rootUuid to the data API response for submissions

📖 Description

The meta/rootUuid field, which serves as a unique identifier per project, has been added to the data API response for submissions. The meta/rootUuid remains unchanged even when a submission is edited, ensuring it consistently represents the original submission. This enhancement allows API consumers to track and reference submissions more effectively using their unique identifiers.

Notes

meta/rootUuid in edit submissions - which was saved without the namespace - is now saved with it to comply to OpenRosa specs and to behave like meta/instanceID and meta/deprecatedID

@noliveleger noliveleger force-pushed the task-1458-inject-root-uuid-in-api-response branch from 9a7441b to d0c2e63 Compare January 21, 2025 16:24
@noliveleger noliveleger changed the title Task 1458 inject root UUID in api response inject root UUID in api response TASK-1458 Jan 21, 2025
@noliveleger noliveleger added API Changes related to API endpoints Back end labels Jan 21, 2025
@noliveleger noliveleger self-assigned this Jan 21, 2025
@noliveleger noliveleger force-pushed the task-1458-inject-root-uuid-in-api-response branch from d0c2e63 to 8d52517 Compare January 21, 2025 16:27
@noliveleger noliveleger changed the title inject root UUID in api response TASK-1458 feat(api): add submission unique identifier (meta/rootUuid) in data API response TASK-1458 Jan 21, 2025
@noliveleger noliveleger requested review from jnm and removed request for jnm January 21, 2025 16:35
@noliveleger noliveleger marked this pull request as ready for review January 21, 2025 16:35
@noliveleger noliveleger requested a review from jnm as a code owner January 21, 2025 16:35
@noliveleger noliveleger removed the request for review from jnm January 21, 2025 16:35
Copy link
Contributor

@rajpatel24 rajpatel24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the failing tests

@rajpatel24 rajpatel24 self-requested a review January 22, 2025 09:11
@noliveleger noliveleger force-pushed the task-1458-inject-root-uuid-in-api-response branch from 6219bfe to 217b10b Compare January 23, 2025 09:16
@noliveleger noliveleger force-pushed the task-1458-inject-root-uuid-in-api-response branch from a27ed15 to efd05b3 Compare January 23, 2025 09:53
@noliveleger noliveleger changed the title feat(api): add submission unique identifier (meta/rootUuid) in data API response TASK-1458 feat(submissions)!: add submission unique identifier (meta/rootUuid) in data API response TASK-1458 Jan 23, 2025
Copy link
Contributor

@rajpatel24 rajpatel24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p2edwards
Copy link
Contributor

I'll start the frontend as a branch targeting this PR

@noliveleger noliveleger requested a review from Guitlle as a code owner February 10, 2025 19:09
…uid' (#5476)

See PR description and comments for more details

- #5476

Frontend compatibility for the backend PR, #5435

- #5435

Co-authored-by: Olivier Leger <[email protected]>
@p2edwards p2edwards removed the request for review from magicznyleszek February 10, 2025 20:29
@noliveleger noliveleger merged commit 7ea3403 into release/2.025.02 Feb 11, 2025
7 checks passed
@noliveleger noliveleger deleted the task-1458-inject-root-uuid-in-api-response branch February 11, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes related to API endpoints Back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants