Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accessLogsExport): add padding to the 'Log Out of All Devices' button on the Security page TASK-1510 #5482

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(accessLogsExport): add padding to the 'Log Out of All Devices' button on the Security page TASK-1510 #5482

merged 2 commits into from
Feb 4, 2025

Conversation

RuthShryock
Copy link
Member

@RuthShryock RuthShryock commented Feb 3, 2025 •
edited
Loading

👀 Preview steps

Bug template:

  1. ℹ️ have an account and a project
  2. Navigate to the Security page
  3. 🔴 [on main] notice that the "Log out of all devices" button is running into the export button
  4. 🟢 [on PR] notice that the "Log out of all devices" button is properly padded

@RuthShryock RuthShryock self-assigned this Feb 3, 2025
@RuthShryock RuthShryock changed the title fix(accessLogsExport): add padding to the 'Log Out of All Devices' button on the Security page fix(accessLogsExport): add padding to the 'Log Out of All Devices' button on the Security page TASK-1510 Feb 3, 2025
jamesrkiger
jamesrkiger approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jamesrkiger jamesrkiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RuthShryock RuthShryock merged commit 8c43ee4 into main Feb 4, 2025
7 checks passed
@RuthShryock RuthShryock deleted the task-1510-fix-button-padding branch February 4, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrkiger jamesrkiger jamesrkiger approved these changes

Assignees

@RuthShryock RuthShryock

Labels
Front end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuthShryock @jamesrkiger