Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenRosa)!: exclude forms owned by inactive users from formList #5502

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jnm
Copy link
Member

@jnm jnm commented Feb 7, 2025

📣 Summary

Previously, blank forms for projects owned by deactivated accounts could still be downloaded, e.g. if the project allowed anonymous submissions, or if a still-active user was granted access to submit to the project. This change prevents access for data collection purposes, i.e. by Enketo or Collect, to forms owned by inactive users. See also #5321.

👀 Preview steps

  1. Log in as a normal user (let's call them "Psy")
  2. Create a project and deploy it
  3. Set the project to allow anonymous submissions
  4. Open Enketo for the project and note the URL
  5. Use a superuser account to deactivate Psy's account (uncheck the "active" box in Django admin)
  6. In a separate browser session, attempt to access the same Enketo URL
    • If you use the same browser session where you initially loaded Enketo, you may need to wait several minutes or refresh multiple times before you observe a change
  7. See "Loading Error / This form is no longer available"

@jnm jnm added the Back end label Feb 7, 2025
@jnm jnm requested a review from noliveleger as a code owner February 7, 2025 19:03
@jnm jnm merged commit eef616f into release/2.025.02 Feb 11, 2025
4 checks passed
@jnm jnm deleted the exclude-forms-of-inactive-users-from-formlist branch February 11, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants