Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projectTransferOwnership): typo causing attachment transfers to fail #5507

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Feb 11, 2025

📣 Summary

Fixed a typo that caused attachment transfers to fail during project ownership transfer.

📖 Description

A typo in the project ownership transfer logic prevented attachments from being properly transferred along with the project. This issue caused attachments to remain associated with the previous owner, leading to inconsistencies and potential data access problems.

Notes

A new management comments has been added to fix failed transfers resume_failed_transfers_2_024_33f

👀 Preview steps

Bug template:

  1. ℹ️ have an account and a project (with attachments)
  2. Submit data with attachments
  3. Transfer the project to another user
  4. 🔴 [on main] notice that the transfer fails
  5. 🟢 [on PR] notice that the transfer succeeds

@noliveleger noliveleger changed the base branch from main to release/2.024.36 February 11, 2025 12:42
@noliveleger noliveleger marked this pull request as ready for review February 11, 2025 12:43
@noliveleger noliveleger self-assigned this Feb 11, 2025
@noliveleger noliveleger force-pushed the fix-attachment-transfer branch 3 times, most recently from 4cccb04 to 8400dd1 Compare February 11, 2025 13:00
@noliveleger noliveleger changed the title Fix typo with make attachment transfers fail fix(projectTransferOwnership): typo causing attachment transfers to fail Feb 11, 2025
@noliveleger noliveleger force-pushed the fix-attachment-transfer branch from 8400dd1 to 43f221c Compare February 11, 2025 16:01
Copy link
Contributor

@rajpatel24 rajpatel24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noliveleger noliveleger merged commit 54dd146 into release/2.024.36 Feb 11, 2025
6 checks passed
@noliveleger noliveleger deleted the fix-attachment-transfer branch February 11, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants