-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Collection Atomic Swaps support #11319
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for polkadot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # components/trade/TradeOwnerButton.vue # components/trade/overviewModal/TradeOverviewModal.vue # composables/useIsTrade.ts
# Conflicts: # composables/useTrades.ts
- ref: removed duplicate code
https://deploy-preview-11319--koda-canary.netlify.app/ahk/collection/379/swaps |
the issue is that some offers/swaps have wrong data due to a bug in the indexers, which has been already fixed but not deployed cc @vikiival alternatively you can run this branch locally andreplace the indexer urls with
inside |
Can promote the squids @hassnian done |
@Jarsen136 the indexer bug is deployed , could you try again |
It's still the same on the offers tab. https://deploy-preview-11319--koda-canary.netlify.app/ahk/collection/379/swaps There is another issue that may not related to this PR. I can click the "accept" button on the expired offer. |
fixed
I'm using the for these swaps so it's an indexer issue cc @vikiival data
|
Can you please open an issue at kodadot/stick ? |
# Conflicts: # components/trade/TradeOwnerButton.vue # components/trade/overviewModal/Details.vue # composables/useTrades.ts
…into issue-11116
can you please fix the conflicts @hassnian ? |
# Conflicts: # components/common/ConnectWallet/WalletAssetMenu.vue
done |
Quality Gate passedIssues Measures |
missing review @preschian @Jarsen136 , thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not tested, code lgtm
PR Type
Context
offers
tab in collectiondesiredItem
Screenshot 📸
Accept Collection Atomic Swap
Offer tab in Collection
Incoming Trades & Create swap tab