Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide other language #11455

Merged
merged 6 commits into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions components/Navbar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -182,22 +182,6 @@

<div class="lg:!hidden">
<template v-if="!account">
<MobileExpandableSection
v-slot="{ onCloseMobileSubMenu }"
class="mobile-language"
:no-padding="true"
:title="$t('profileMenu.language')"
icon="globe"
>
<MobileLanguageOption
@select="
() => {
showMobileNavbar()
onCloseMobileSubMenu()
}
"
/>
</MobileExpandableSection>
<ColorModeButton class="navbar-item" />
<NavbarCookiesButton @select="showMobileNavbar" />
</template>
Expand Down Expand Up @@ -256,7 +240,6 @@ import { openConnectWalletModal } from '@/components/common/ConnectWallet/useCon
import ChainSelectDropdown from '@/components/navbar/ChainSelectDropdown.vue'
import CreateDropdown from '@/components/navbar/CreateDropdown.vue'
import MobileExpandableSection from '@/components/navbar/MobileExpandableSection.vue'
import MobileLanguageOption from '@/components/navbar/MobileLanguageOption.vue'
import NavbarChainOptions from '@/components/navbar/NavbarChainOptions.vue'
import NavbarExploreOptions from '@/components/navbar/NavbarExploreOptions.vue'
import Search from '@/components/search/Search.vue'
Expand Down
43 changes: 1 addition & 42 deletions components/common/ConnectWallet/WalletAssetMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,43 +22,6 @@
<div class="wallet-asset-footer flex py-5 text-xs text-k-grey">
<!-- light/dark mode -->
<ColorModeSwitch />

<!-- language -->
<div
data-testid="sidebar-language"
class="language-selector"
>
<NeoDropdown
position="top-left"
aria-role="menu"
mobile-modal
>
<template #trigger>
<div class="flex items-center">
<NeoIcon
icon="globe"
size="medium"
/>
<span class="is-hidden-mobile ml-1">
{{ $t('profileMenu.language') }}
</span>
</div>
</template>

<NeoDropdownItem
v-for="lang in langsFlags"
:key="lang.value"
aria-role="listitem"
:data-testid="`sidebar-language-${lang.value}`"
:value="lang.value"
:class="{ 'is-active': $i18n.locale === lang.value }"
@click="usePreferencesStore().setUserLocale(lang.value)"
>
<span>{{ lang.flag }} {{ lang.label }}</span>
</NeoDropdownItem>
</NeoDropdown>
</div>

<!-- settings -->
<nuxt-link
to="/settings"
Expand All @@ -77,7 +40,7 @@
</template>

<script setup lang="ts">
import { NeoDropdown, NeoDropdownItem, NeoIcon } from '@kodadot1/brick'
import { NeoIcon } from '@kodadot1/brick'
import type { Prefix } from '@kodadot1/static'
import { transferVisible, teleportVisible, swapVisible } from '@/utils/config/permission.config'

Expand Down Expand Up @@ -130,10 +93,6 @@ const closeModal = () => {

@apply bulma-mobile:justify-center;

.language-selector {
@apply bulma-mobile:my-8 bulma-mobile:mx-0;
}

& > * {
@apply cursor-pointer flex gap-1;

Expand Down
44 changes: 1 addition & 43 deletions components/navbar/ProfileDropdown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@
</a>
</template>

<NeoDropdownItem aria-role="menuitem">
<div
class="flex items-center"
@click="toggleLanguageMenu"
>
{{ $t('profileMenu.language') }}&nbsp;<NeoIcon icon="globe" />
</div>
</NeoDropdownItem>
<NeoDropdownItem aria-role="menuitem">
<ColorModeButton />
</NeoDropdownItem>
Expand All @@ -56,37 +48,11 @@
/>
</div>
</div>

<NeoDropdown
ref="languageDropdown"
position="bottom-left"
aria-role="menu"
:toggle="toggleLanguageMenu"
>
<NeoDropdownItem
aria-role="listitem"
class="is-active flex items-center language-heading text-base"
@click="toggleLanguageMenu"
>
<span>{{ $t('profileMenu.language') }} <NeoIcon icon="globe" /></span>
</NeoDropdownItem>

<NeoDropdownItem
v-for="lang in langsFlags"
:key="lang.value"
aria-role="listitem"
:value="lang.value"
:class="{ 'is-active': $i18n.locale === lang.value }"
@click="usePreferencesStore().setUserLocale(lang.value)"
>
<span>{{ lang.flag }} {{ lang.label }}</span>
</NeoDropdownItem>
</NeoDropdown>
</div>
</template>

<script lang="ts" setup>
import { NeoDropdown, NeoDropdownItem, NeoIcon } from '@kodadot1/brick'
import { NeoDropdown, NeoDropdownItem } from '@kodadot1/brick'

import { useIdentityStore } from '@/stores/identity'
import { useProfileOnboardingStore } from '@/stores/profileOnboarding'
Expand All @@ -98,8 +64,6 @@ const identityStore = useIdentityStore()
const { isDarkMode } = useTheme()
const { neoModal } = useProgrammatic()

const languageDropdown = ref(null)

const account = computed(() => identityStore.getAuthAddress)
const profileIcon = computed(() =>
isDarkMode.value ? '/profile-dark.svg' : '/profile.svg',
Expand All @@ -113,10 +77,4 @@ const toggleWalletConnectModal = () => {
openConnectWalletModal()
}
}

const toggleLanguageMenu = () => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
languageDropdown.value?.toggle()
}
</script>
32 changes: 0 additions & 32 deletions stores/lang.ts

This file was deleted.

2 changes: 2 additions & 0 deletions stores/preferences.ts
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,8 @@ export const usePreferencesStore = defineStore('preferences', {
},
setUserLocale(locale: string) {
const { $i18n } = useNuxtApp()
// only supports en for now
locale = 'en'
$i18n.locale.value = locale
this.userLocale = locale
},
Expand Down
50 changes: 0 additions & 50 deletions tests/e2e/language.spec.ts

This file was deleted.