Merge pull request #26 from koide3/leak

fix memory leak
koide3 · Oct 22, 2024 · 13d3bb7 · 13d3bb7
2 parents 53743e6 + 4e9d9ac
commit 13d3bb7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/include/gtsam_points/optimizers/incremental_fixed_lag_smoother_with_fallback.hpp b/include/gtsam_points/optimizers/incremental_fixed_lag_smoother_with_fallback.hpp
@@ -26,13 +26,13 @@ class IncrementalFixedLagSmootherExtWithFallback : public IncrementalFixedLagSmo
   template <class VALUE>
   VALUE calculateEstimate(Key key) const {
     try {
-      const auto& value = smoother->calculateEstimate(key);
+      const VALUE value = smoother->calculateEstimate<VALUE>(key);
       auto found = values.find(key);
       if (found != values.end()) {
-        found->value = value;
+        values.insert_or_assign(key, value);
       }
 
-      return value.cast<VALUE>();
+      return value;
     } catch (std::exception& e) {
       std::cerr << "warning: an exception was caught in fixed-lag smoother update!!" << std::endl;
       std::cerr << "       : " << e.what() << std::endl;