Document SYCL backend behavior with no selected GPU architecture #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Jan 30, 2025
Comment on lines
+737
to
+740
| If the SYCL backend is enabled and no GPU architecture is specified, | ||
| Kokkos will use Just-In-Time (JIT) compilation and select the first visible device for the default execution space instance. | ||
| There is no restriction to a particular SYCL device type. | ||
| Thus, this is the only option to target a CPU with the SYCL backend (which is experimental, untested, and not optimized for). |
There was a problem hiding this comment.
Does that imply we define Kokkos_ARCH_INTEL_GEN=ON if no Intel GPU arch is enabled or is it more subtle than that?
There was a problem hiding this comment.
No, we can't assume that we are building for an Intel GPU so we don't define enable any extra Kokkos_ARCH* options.
dalg24
reviewed
Jan 30, 2025
| @@ -734,6 +734,11 @@ Kokkos will attempt to autodetect the architecture flag at configuration time. | |||
| Intel GPUs | |||
| ~~~~~~~~~~ | |||
|
|
|||
| If the SYCL backend is enabled and no GPU architecture is specified, | |||
| Kokkos will use Just-In-Time (JIT) compilation and select the first visible device for the default execution space instance. | |||
There was a problem hiding this comment.
Although the discussion about device selection is important, I am not sure it belongs here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #619.