symmetric_matrix_rank_1_update: kokkos impl
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzuzek
force-pushed
the
blas2_symmetric-matrix-rank1-update_kokkos_impl
branch
2 times, most recently
from
d707a71 to
9903b48
Compare
|
@fnrizzi has been touching a lot of this code of late, but it looks like you know that : - ) I'll wait until you two say it's ready to merge. |
|
@mhoemmen yes, I have a plan with @MikolajZuzek so he is doing all the *_update functions :) so you can safely review this since it does not interfere with anything i am doing! |
mhoemmen
requested changes
Apr 10, 2022
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
|
@MikolajZuzek Thanks for working on this, btw! : - ) |
mzuzek
force-pushed
the
blas2_symmetric-matrix-rank1-update_kokkos_impl
branch
2 times, most recently
from
1c06d51 to
c209631
Compare
mhoemmen
reviewed
Apr 13, 2022
mhoemmen
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Thanks for the fixes! I'm OK merging this, but there are a couple issues remaining:
- some use of
std::complexin aKOKKOS_LAMBDA; not sure if OK; and - a couple spelling errors in comments.
If you're in a hurry, I'll be happy to merge this, else I'll wait for fixes. Thanks!
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Outdated
Show resolved
Hide resolved
@mhoemmen Thank you for your thorough reviews and great comments! No hurry on my part: it's better to find and fix as many things as we can, so they don't get duplicated on other PRs. |
mzuzek
force-pushed
the
blas2_symmetric-matrix-rank1-update_kokkos_impl
branch
3 times, most recently
from
bde2330 to
83d1742
Compare
mzuzek
force-pushed
the
blas2_symmetric-matrix-rank1-update_kokkos_impl
branch
from
83d1742 to
5287348
Compare
mzuzek
force-pushed
the
blas2_symmetric-matrix-rank1-update_kokkos_impl
branch
from
5287348 to
3628b87
Compare
mhoemmen
reviewed
Apr 15, 2022
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_1_update.hpp
Show resolved
Hide resolved
mhoemmen
approved these changes
Apr 15, 2022
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Kokkos implementation of
symmetric_matrix_rank_1_update.