Skip to content

Commit

Permalink
url
Browse files Browse the repository at this point in the history
Signed-off-by: André Bauer <[email protected]>
  • Loading branch information
monotek committed Jul 4, 2024
1 parent 25d300e commit 476b9e2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
2 changes: 2 additions & 0 deletions charts/visual-regression-tracker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ _See [`helm upgrade`](https://helm.sh/docs/helm/helm_upgrade/) for command docum

Auth proxy was removed as it does nto work as expected.

The `reactAppApi.protocol` & `reactAppApi.url` have been removed and `reactAppApiUrl` is used again.

### From 3.0.x to 4.0.0

This version adds a proxy in fornt of the API server which protects it via basic auth. The configuration can be done via `authProxy.basicAuth.username`, `authProxy.basicAuth.password`. The password can also be populated by predefined secret via `secrets.authProxy`.
Expand Down
7 changes: 1 addition & 6 deletions charts/visual-regression-tracker/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,8 @@ spec:
mountPath: /imageUploads
- name: {{ .Chart.Name }}-ui
env:
- name: BASIC_AUTH_PASSWORD
valueFrom:
secretKeyRef:
name: {{ template "visual-regression-tracker.authProxySecretName" . }}
key: {{ .Values.secrets.authProxy.secretKey }}
- name: REACT_APP_API_URL
value: "{{ .Values.vrtConfig.reactAppApi.protocol }}://{{ .Values.authProxy.basicAuth.username }}:$(BASIC_AUTH_PASSWORD)@{{ .Values.vrtConfig.reactAppApi.url }}"
value: "{{ .Values.vrtConfig.reactAppApiUrl }}"
- name: VRT_VERSION
value: "{{ .Chart.AppVersion }}"
image: "{{ .Values.vrtComponents.ui.image.repository }}:{{ .Values.vrtComponents.ui.image.tag }}"
Expand Down
5 changes: 1 addition & 4 deletions charts/visual-regression-tracker/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,7 @@ vrtConfig:
port: 5432
# needs to be the same as the postgresql.auth.username
user: vrt
reactAppApi:
# the basic auth username & password are included automaticaly
protocol: "http"
url: "localhost:4200"
reactAppApiUrl: "http://localhost:4200"

vrtComponents:
api:
Expand Down

0 comments on commit 476b9e2

Please sign in to comment.