Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
Signed-off-by: André Bauer <[email protected]>
  • Loading branch information
monotek committed Jun 27, 2024
1 parent 15f6eb9 commit 4e066bc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/visual-regression-tracker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ This version adds a proxy in fornt of the API server which protects it via basic

The `secrets.apiUrl` secrets has been removed.

The `reactAppApiUrl` variables has been split up into `reactAppApi.protocol`, `reactAppApi.url` & `reactAppApi.port`.
The `reactAppApiUrl` variables has been split up into `reactAppApi.protocol` & `reactAppApi.url`.

The `vrtComponents.api.ingress` config has been moved to `authProxy.ingress`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ spec:
name: {{ template "visual-regression-tracker.authProxySecretName" . }}
key: {{ .Values.secrets.authProxy.secretKey }}
- name: REACT_APP_API_URL
value: "{{ .Values.vrtConfig.reactAppApi.protocol }}://{{ .Values.authProxy.basicAuth.username }}:$(BASIC_AUTH_PASSWORD)@{{ .Values.vrtConfig.reactAppApi.protocol }}"
value: "{{ .Values.vrtConfig.reactAppApi.protocol }}://{{ .Values.authProxy.basicAuth.username }}:$(BASIC_AUTH_PASSWORD)@{{ .Values.vrtConfig.reactAppApi.url }}"
- name: VRT_VERSION
value: "{{ .Chart.AppVersion }}"
image: "{{ .Values.vrtComponents.ui.image.repository }}:{{ .Values.vrtComponents.ui.image.tag }}"
Expand Down
3 changes: 1 addition & 2 deletions charts/visual-regression-tracker/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ vrtConfig:
user: vrt
reactAppApi:
protocol: "http"
url: "localhost"
port: "4200"
url: "localhost:4200"

vrtComponents:
api:
Expand Down

0 comments on commit 4e066bc

Please sign in to comment.