Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vrt] update 5.0.5 #185

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[vrt] update 5.0.5 #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77a2915
update 5.0.5
monotek Jun 25, 2024
6b17ce5
make api url a secret
monotek Jun 25, 2024
71e0508
no helm upgrade in ci
monotek Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ct.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ check-version-increment: true
debug: true
helm-extra-args: --timeout 600s
target-branch: main
upgrade: true
6 changes: 3 additions & 3 deletions charts/visual-regression-tracker/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ sources:
- https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker
- https://github.com/kokuwaio/helm-charts/tree/main/charts/visual-regression-tracker
type: application
version: 3.1.0
appVersion: "5.0.3"
version: 3.2.0
appVersion: "5.0.4"
maintainers:
- name: monotek
email: [email protected]
dependencies:
- name: postgresql
version: 13.3.0
version: 15.5.10
repository: https://charts.bitnami.com/bitnami
condition: vrtConfig.postgresql.enabled
11 changes: 11 additions & 0 deletions charts/visual-regression-tracker/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,14 @@ vrt secret name
{{ template "visual-regression-tracker.fullname" . }}-{{ .Values.secrets.defaults.secretName }}
{{- end -}}
{{- end -}}

{{/*
vrt api url secret name
*/}}
{{- define "visual-regression-tracker.vrtApiUrlSecretName" -}}
{{- if .Values.secrets.apiUrl.useExisting -}}
{{ .Values.secrets.apiUrl.secretName }}
{{- else -}}
{{ template "visual-regression-tracker.fullname" . }}-{{ .Values.secrets.apiUrl.secretName }}
{{- end -}}
{{- end -}}
12 changes: 12 additions & 0 deletions charts/visual-regression-tracker/templates/secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,15 @@ type: Opaque
data:
{{ .Values.secrets.defaults.secretKey }}: {{ tpl (.Files.Get "files/seed.ts") $ | b64enc }}
{{ end }}
{{ if and .Values.vrtConfig.reactAppApiUrl (not .Values.secrets.apiUrl.useExisting) }}
---
apiVersion: v1
kind: Secret
metadata:
name: {{ template "visual-regression-tracker.vrtApiUrlSecretName" . }}
labels:
{{- include "visual-regression-tracker.labels" . | nindent 4 }}
type: Opaque
data:
{{ .Values.secrets.apiUrl.secretKey }}: {{ .Values.vrtConfig.reactAppApiUrl | b64enc | quote }}
{{ end }}
5 changes: 4 additions & 1 deletion charts/visual-regression-tracker/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ spec:
- name: {{ .Chart.Name }}-ui
env:
- name: REACT_APP_API_URL
value: "{{ .Values.vrtConfig.reactAppApiUrl }}"
valueFrom:
secretKeyRef:
name: {{ template "visual-regression-tracker.vrtApiUrlSecretName" . }}
key: {{ .Values.secrets.apiUrl.secretKey }}
- name: VRT_VERSION
value: "{{ .Chart.AppVersion }}"
image: "{{ .Values.vrtComponents.ui.image.repository }}:{{ .Values.vrtComponents.ui.image.tag }}"
Expand Down
6 changes: 5 additions & 1 deletion charts/visual-regression-tracker/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ vrtComponents:
image:
repository: visualregressiontracker/api
pullPolicy: IfNotPresent
tag: "5.0.4"
tag: "5.0.5"

ingress:
enabled: false
Expand Down Expand Up @@ -171,6 +171,10 @@ persistence:
annotations: {}

secrets:
apiUrl:
useExisting: false
secretKey: api-url
secretName: vrt-api-url
defaults:
useExisting: false
secretName: vrt
Expand Down