deny default write permissions from windows root directory #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
previously approved these changes
Nov 19, 2024
James-Pickett
previously approved these changes
Nov 19, 2024
zackattack01
dismissed stale reviews from James-Pickett and RebeccaMahany
via
d129718
zackattack01
force-pushed
the
zack/update_windows_rootdir_permissions
branch
from
41e3c19
to
d129718
Compare
cmd/launcher/svc_config_windows.go
Outdated
| // if there is already a DENY entry set for user's group to avoid recreating every time | ||
| for i := 0; i < int(existingDACL.AceCount); i++ { | ||
| var ace *windows.ACCESS_ALLOWED_ACE | ||
| err = windows.GetAce(existingDACL, uint32(i), &ace) |
There was a problem hiding this comment.
reusing err in here always feels fixy. Can we use the common if err := ... form?
RebeccaMahany
approved these changes
Nov 19, 2024
James-Pickett
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds an additional check to the windows_svc_config startup routine to verify permissions for the configured root directory. I do not love the concept of adding an explicit denial instead of just removing the existing grant, but this has been the only way i've seen success so far, after trying several different ways to do this.
Once the changes run I am no longer able to create/write nested directories inside of the root directory without using an admin console. Subsequent runs see the entry exists and skip before making further changes.
Follow up PRs will attempt to set the proper directory permissions on package install