-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript, vite and vitest #287
base: main
Are you sure you want to change the base?
Conversation
cc4d0ce
to
5b6bad5
Compare
5b6bad5
to
2f2cf47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I really appreciate your contribution—great job on this! 🎉
I’ve left a few comments for review.
Additionally, I wanted to confirm, have you tested whether Webpack-based Editor.js projects using the plugin remain unaffected? 🤔
Since the previous setup relied on Webpack’s UMD output, I just want to make sure the transition doesn’t introduce compatibility issues for users relying on CommonJS or direct browser usage, also ensure the commits are correctly signed.
Looking forward to your update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file lacks of an EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file lacks of an EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file lacks of an EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes thanks, sorry about that, I'll manage that tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @L-Zuluaga,
I've just pushed to fix it.
I took advantage of this fix to add eslint-config-prettier
plugin on the project and add vscode settings samples and recommanded extensions to help for application of contribution guidelines.
Tell me if it's ok for you!
Arf no you're right, I didn't test it on a webpack project or direct browser usage, i'm not sure about compatibility. |
2f2cf47
to
3d8e480
Compare
Add typescript to the project.
Change webpack to vite for build.
Use vitest and rewrite test.
Depends on #286