Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript, vite and vitest #287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NansPellicari
Copy link

@NansPellicari NansPellicari commented Feb 14, 2025

Add typescript to the project.
Change webpack to vite for build.
Use vitest and rewrite test.
Depends on #286

@NansPellicari NansPellicari force-pushed the feat/vite-and-ts branch 3 times, most recently from cc4d0ce to 5b6bad5 Compare February 14, 2025 14:01
@L-Zuluaga L-Zuluaga linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I really appreciate your contribution—great job on this! 🎉
I’ve left a few comments for review.

Additionally, I wanted to confirm, have you tested whether Webpack-based Editor.js projects using the plugin remain unaffected? 🤔
Since the previous setup relied on Webpack’s UMD output, I just want to make sure the transition doesn’t introduce compatibility issues for users relying on CommonJS or direct browser usage, also ensure the commits are correctly signed.

Looking forward to your update!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file lacks of an EOL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file lacks of an EOL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file lacks of an EOL

Copy link
Author

@NansPellicari NansPellicari Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes thanks, sorry about that, I'll manage that tomorrow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @L-Zuluaga,
I've just pushed to fix it.
I took advantage of this fix to add eslint-config-prettier plugin on the project and add vscode settings samples and recommanded extensions to help for application of contribution guidelines.
Tell me if it's ok for you!

@NansPellicari
Copy link
Author

Hi, I really appreciate your contribution—great job on this! 🎉 I’ve left a few comments for review.

Additionally, I wanted to confirm, have you tested whether Webpack-based Editor.js projects using the plugin remain unaffected? 🤔 Since the previous setup relied on Webpack’s UMD output, I just want to make sure the transition doesn’t introduce compatibility issues for users relying on CommonJS or direct browser usage, also ensure the commits are correctly signed.

Looking forward to your update!

Arf no you're right, I didn't test it on a webpack project or direct browser usage, i'm not sure about compatibility.
I'll test it next week and keep you in touch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript support
2 participants