Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 4h task timeout in the ec pipeline #1830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dirgim
Copy link
Contributor

@dirgim dirgim commented Jan 17, 2025

Since the default timeout for tasks is hardcoded to 1h/2h, this change sets the timeout to a higher value to
support users who run bigger sets of images through the verify task.

It is still possible to limit the duration of the check on the pipeline or pipelineRun level, depending on usage.

Signed-off-by: dirgim [email protected]

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@dirgim dirgim requested review from lcarva and jsztuka January 17, 2025 13:18
@dirgim dirgim requested a review from a team as a code owner January 17, 2025 13:18
Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dirgim dirgim requested a review from simonbaird January 17, 2025 13:23
@dirgim
Copy link
Contributor Author

dirgim commented Jan 17, 2025

/retest

@chmeliik
Copy link
Contributor

chmeliik commented Jan 17, 2025

FYI there's also #1613

Since the default timeout for tasks is hardcoded to 1h/2h,
this change sets the timeout to a higher value to
support users who run bigger sets of images through
the verify task.

It is still possible to limit the duration of the check
on the pipeline or pipelineRun level, depending on usage.

Signed-off-by: dirgim <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@dirgim
Copy link
Contributor Author

dirgim commented Jan 17, 2025

FYI there's also #1613

Ack, but it seems to have stalled, hence I'm proposing this solution in order to unblock users who are running into the hardcoded 2h timeout. If that PR does get unblocked quickly, I'd be happy to close this one.

@dirgim dirgim requested a review from ralphbean January 17, 2025 15:56
@chmeliik
Copy link
Contributor

Yeah, apparently there was a problem with it, Martin even tried to resolve it but didn't work #1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants