feat(RHTAPREL-119): make target optional in ReleasePlans #279
Conversation
If a user wants to run a dev release pipeline with no managed release pipeline, it really doesn't make sense to have a target workspace. This commit makes the target workspace optional instead of required in the ReleasePlan Spec. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
requested review from
a team,
theflockers,
davidmogar,
mmalina,
scoheb,
kasemAlem,
happybhati and
Troy876
and removed request for
a team
|
@johnbieren: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -47,7 +47,7 @@ type ReleasePlanSpec struct { | |||
|
|
|||
| // Target references where to send the release requests | |||
| // +kubebuilder:validation:Pattern=^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ | |||
| // +required | |||
| // +optional | |||
There was a problem hiding this comment.
does this require any special handling in the controller since it might expect this is required?
There was a problem hiding this comment.
hmm probably? but I'm not sure we need to handle it yet; it can likely be handled in the PR that adds support for the dev pipelines. Maybe this is better off as part of that PR instead. @davidmogar thoughts?
There was a problem hiding this comment.
Yeah, probably better to add it there.
If a user wants to run a dev release pipeline with no managed release pipeline, it really doesn't make sense to have a target workspace. This commit makes the target workspace optional instead of required in the ReleasePlan Spec.