Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RHTAPREL-711): add shortnames to CRDs #299

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat(RHTAPREL-711): add shortnames to CRDs #299

merged 1 commit into from
Nov 14, 2023

Conversation

johnbieren
Copy link
Collaborator

Add the rp shortname for ReleasePlan and rpa shortname for ReleasePlanAdmission.

$ oc get rp
NAME   APPLICATION   TARGET
rp     foo           rpas

$ oc get rpa
NAME   ENVIRONMENT   ORIGIN
rpa    production    rpas

@johnbieren johnbieren requested review from a team, theflockers, ralphbean, davidmogar, mmalina, jinqi7, happybhati and Troy876 and removed request for a team November 13, 2023 16:29
happybhati
happybhati previously approved these changes Nov 13, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8ea22f) 84.07% compared to head (ffb8188) 84.07%.
Report is 3 commits behind head on main.

❗ Current head ffb8188 differs from pull request most recent head 18e2775. Consider uploading reports for the commit 18e2775 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files          25       25           
  Lines        1501     1501           
=======================================
  Hits         1262     1262           
  Misses        175      175           
  Partials       64       64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mmalina
mmalina previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@mmalina mmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

davidmogar
davidmogar requested changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@davidmogar davidmogar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been in my bucket list for a long time. Thanks for creating the PR.

Could you please, add as well rsc for ReleaseServiceConfig and rel for Release?

@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2023
@johnbieren johnbieren dismissed stale reviews from mmalina and happybhati via ffb8188 November 14, 2023 12:49
@johnbieren
feat(RHTAPREL-711): add shortnames to CRDs
18e2775 
Add the rp shortname for ReleasePlan, rpa shortname for
ReleasePlanAdmission, rsc shortname for ReleaseServiceConfig, and rel
shortname for Release.

Signed-off-by: Johnny Bieren <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2023
@johnbieren johnbieren merged commit 9eb7793 into konflux-ci:main Nov 14, 2023
@johnbieren johnbieren deleted the rel711 branch November 14, 2023 14:40
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Nov 14, 2023
Merged
@scoheb scoheb mentioned this pull request Nov 14, 2023
Merged
@scoheb scoheb mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmogar davidmogar davidmogar approved these changes

@mmalina mmalina mmalina left review comments

@happybhati happybhati happybhati left review comments

@theflockers theflockers Awaiting requested review from theflockers

@ralphbean ralphbean Awaiting requested review from ralphbean

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@Troy876 Troy876 Awaiting requested review from Troy876

Assignees

@davidmogar davidmogar

@mmalina mmalina

@happybhati happybhati

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnbieren @davidmogar @mmalina @happybhati