Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1307): increases lease timeout #617

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theflockers
Copy link
Collaborator

this PR proposes a change in the default leader election
time controls to decrease the etcd load and allowing the
to wait time to renew the leadership, and also decreasing
the number of requests to etcd.

Signed-off-by: Leandro Mendes <[email protected]>

Copy link

openshift-ci bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.67%. Comparing base (40d3987) to head (883ea4c).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   79.21%   78.67%   -0.55%     
==========================================
  Files          28       28              
  Lines        2247     2260      +13     
==========================================
- Hits         1780     1778       -2     
- Misses        384      398      +14     
- Partials       83       84       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theflockers theflockers force-pushed the increase_lease_timeout branch 2 times, most recently from 3a0d9b1 to 70a0bb1 Compare December 3, 2024 09:21
this PR proposes a change in the default leader election
time controls to decrease the etcd load and allowing the
to wait time to renew the leadership, and also decreasing
the number of requests to etcd.

Signed-off-by: Leandro Mendes <[email protected]>
@theflockers theflockers force-pushed the increase_lease_timeout branch from 70a0bb1 to 883ea4c Compare January 10, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant