Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release preparation #37

Merged
merged 27 commits into from
Jan 12, 2024
Merged

Release preparation #37

merged 27 commits into from
Jan 12, 2024

Conversation

pokornyd
Copy link
Member

@pokornyd pokornyd commented Nov 28, 2023

Motivation

Fixes #12 #30 #2 #26 #22

Tasks in DEVREL-1019

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to update dependencies, especially our SDK and the public dependencies. There are quite a few old version some even by several major versions behind.
image

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (32e883a) 93.47% compared to head (7a8533a) 94.58%.

Files Patch % Lines
src/utils/common-utils.ts 73.07% 7 Missing ⚠️
...able-text-transformer/portable-text-transformer.ts 94.11% 4 Missing ⚠️
src/utils/transformer-utils.ts 97.61% 2 Missing ⚠️
src/parser/node/rich-text-node-parser.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   93.47%   94.58%   +1.11%     
==========================================
  Files          15       17       +2     
  Lines         337      351      +14     
  Branches       66       67       +1     
==========================================
+ Hits          315      332      +17     
+ Misses         22       19       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokornyd pokornyd changed the title Release 1.0.0 Release preparation Dec 10, 2023
@IvanKiral
Copy link
Contributor

merge first

@pokornyd pokornyd force-pushed the release branch 2 times, most recently from 4b0d39b to 5c5ce33 Compare January 8, 2024 21:34
@JiriLojda JiriLojda self-requested a review January 9, 2024 16:20
Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the resolver in both, browser and node environments?

@pokornyd pokornyd force-pushed the release branch 2 times, most recently from 9952601 to 660fe60 Compare January 11, 2024 19:55
@pokornyd
Copy link
Member Author

Did you test the resolver in both, browser and node environments?

tested, seems to be working with rollup, will try webpack before release. tsc on its own doesn't seem to have a working config for a browser ES scenario: https://www.typescriptlang.org/docs/handbook/modules/guides/choosing-compiler-options.html#im-writing-es-modules-for-the-browser-with-no-bundler-or-module-compiler

@pokornyd pokornyd merged commit a5abce8 into main Jan 12, 2024
@pokornyd pokornyd deleted the release branch January 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants