-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release preparation #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 93.47% 94.58% +1.11%
==========================================
Files 15 17 +2
Lines 337 351 +14
Branches 66 67 +1
==========================================
+ Hits 315 332 +17
+ Misses 22 19 -3 ☔ View full report in Codecov by Sentry. |
merge first |
tests/transfomers/portable-text-transformer/portable-text-transformer.spec.ts
Outdated
Show resolved
Hide resolved
src/transformers/portable-text-transformer/portable-text-transformer.ts
Outdated
Show resolved
Hide resolved
4b0d39b
to
5c5ce33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the resolver in both, browser and node environments?
9952601
to
660fe60
Compare
tested, seems to be working with rollup, will try webpack before release. tsc on its own doesn't seem to have a working config for a browser ES scenario: https://www.typescriptlang.org/docs/handbook/modules/guides/choosing-compiler-options.html#im-writing-es-modules-for-the-browser-with-no-bundler-or-module-compiler |
narrow types, move them and consts to utils
refactor TextMark and its creator methods refactor handleLinks, remove unused methods
update jest.config adjust .npmignore
throw if unknown tag is encountered
make traverse function copy instead of mutate
Motivation
Fixes #12 #30 #2 #26 #22
Tasks in DEVREL-1019
transformToPortableText
, allowing customization of each portable text object prior to merging (Define practices for enriching component blocks #26 Provide options to manipulate the Portable Text output #22)Checklist
How to test
If manual testing is required, what are the steps?