chore: fix an issue with upx and mac where the process gets killed im…

…mediately (#441) Issue seems to be with v3.94 of upx that comes installed by default in ubuntu-latest images of Github actions. A number of very similar issues: upx/upx#450 upx/upx#222 Signed-off-by: Harikrishnan Balagopal <[email protected]>
konveyor · Mar 3, 2021 · 0373fc9 · 0373fc9
1 parent 64b2183
commit 0373fc9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -17,8 +17,6 @@ jobs:
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ steps.info.outputs.go_version }}
-      - name: install upx to compress binaries
-        run: sudo apt-get install -y upx
       - run: make ci
       - run: make test-coverage
       - name: upload coverage

diff --git a/.github/workflows/prbuild.yml b/.github/workflows/prbuild.yml
@@ -17,8 +17,6 @@ jobs:
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ steps.info.outputs.go_version }}
-      - name: install upx to compress binaries
-        run: sudo apt-get install -y upx
       - run: make ci
       - run: make test-coverage
       - name: upload coverage

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -29,8 +29,12 @@ jobs:
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ steps.info.outputs.go_version }}
-      - name: install upx to compress binaries
-        run: sudo apt-get install -y upx
+
+      - name: install upx ^3.96 to compress binaries. The default 3.94 version has some issues with MacOS.
+        run: brew install upx
+      - run: ls -al "$(which upx)"
+      - run: upx --version
+
       - run: make ci
       - run: make test-coverage
       - name: upload coverage
@@ -167,8 +171,12 @@ jobs:
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ steps.info.outputs.go_version }}
-      - name: install upx to compress binaries
-        run: sudo apt-get install -y upx
+
+      - name: install upx ^3.96 to compress binaries. The default 3.94 version has some issues with MacOS.
+        run: brew install upx
+      - run: ls -al "$(which upx)"
+      - run: upx --version
+
       - run: VERSION='${{ github.event.inputs.tag }}' make dist
       - name: upload release assets
         uses: HarikrishnanBalagopal/upload-release-action@v3