Skip to content

Commit

Permalink
fix: atomic.Int64 requires go1.19 otherwise breaks (#1152)
Browse files Browse the repository at this point in the history
Signed-off-by: Mehant Kammakomati <[email protected]>
  • Loading branch information
kmehant authored Mar 13, 2024
1 parent fc28c23 commit 565394b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN mkdir -p $GOPATH/src $GOPATH/bin && chmod -R 777 $GOPATH
ENV PATH=$GOPATH/bin:/usr/local/go/bin:$PATH

# Download Go.
ARG GO_VERSION=1.18
ARG GO_VERSION=1.19
ARG TARGETARCH
ARG TARGETOS
ENV TARGETARCH_ENV=${TARGETARCH:-amd64}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

GO_VERSION ?= $(shell go run ./scripts/detectgoversion/detect.go 2>/dev/null || printf '1.18')
GO_VERSION ?= $(shell go run ./scripts/detectgoversion/detect.go 2>/dev/null || printf '1.19')
BINNAME ?= move2kube
IN_CICD ?= false
CGO_ENABLED ?= 0
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Checkout the [Tutorials](https://move2kube.konveyor.io/tutorials) and [Documenta

To browse code [![Open in VSCode](https://badgen.net/badge/icon/Visual%20Studio%20Code?icon=visualstudio&label)](https://open.vscode.dev/konveyor/move2kube)

1. Obtain a recent version of `golang`. Known to work with `1.18`.
1. Obtain a recent version of `golang`. Known to work with `1.19`.
1. Ensure `$GOPATH` is set. If it's not set:
1. `mkdir ~/go`
1. `export GOPATH=~/go`
Expand Down

0 comments on commit 565394b

Please sign in to comment.