Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added test for TestMergeProcessFileCallBack different content case #1129

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

satyazzz123
Copy link
Contributor

@satyazzz123 satyazzz123 commented Jan 14, 2024

i) this test for source and destination files with different content on execution of MergeProcessFileCallBack funcion

fixes a part of #881

Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the test label Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.91%. Comparing base (e53812c) to head (5e6ba40).
Report is 1 commits behind head on main.

❗ Current head 5e6ba40 differs from pull request most recent head ba0231a. Consider uploading reports for the commit ba0231a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   14.89%   14.91%   +0.02%     
==========================================
  Files          90       90              
  Lines        8380     8380              
==========================================
+ Hits         1248     1250       +2     
+ Misses       6809     6805       -4     
- Partials      323      325       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyazzz123
Copy link
Contributor Author

@kmehant @seshapad @HarikrishnanBalagopal I have raised a PR. Please take a look . Thank you

@satyazzz123 satyazzz123 changed the title test: added test for TestMergeDeletionCallBack different content case test: added test for TestMergeProcessFileCallBack different content case Jan 14, 2024
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal enabled auto-merge (squash) March 21, 2024 09:02
@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 14357a9 into konveyor:main Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants