feat : BasicInfo CRUD api 구현 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
확인했습니다. 혹시 회원탈퇴 메서드도 만들어 주실 수 있나요? 회원가입만 계속 했더니 남은 이메일이 없어요 |
|
노션과 PR 내용 둘다 확인했습니다. |
imjanghyeok
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
temporary-password 보다는 verified-code가 더 적절해 보입니다.
There was a problem hiding this comment.
그럼 url 이 auth/verify-verified-code 가 되어서 동어 반복? 이라 조금 어감이 이상한 것 같습니다... 혹시 다른 url 로 고칠만한게 없을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
파트
작업 내용
기타(특이사항 등)
스크린샷 (선택)
💬리뷰 요구사항(선택)
리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요