Fix issue with object id queries (#1073)

* Fix issue with object id queries This resolves an issue where filtering for object ids using the objectIds query parameter with a layer definition applied that also filters for object ids doesn't return the expected results. * Create smart-keys-prove.md --------- Co-authored-by: Rich Gwozdz <[email protected]>
koopjs · Aug 12, 2024 · 642ab7e · 642ab7e
1 parent e665549
commit 642ab7e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/smart-keys-prove.md b/.changeset/smart-keys-prove.md
@@ -0,0 +1,5 @@
+---
+"@koopjs/winnow": patch
+---
+
+Fix issue with object id queries
diff --git a/packages/winnow/src/sql-query-builder/where-builder/index.js b/packages/winnow/src/sql-query-builder/where-builder/index.js
@@ -8,7 +8,7 @@ const timestampWithoutZoneRegex = /^\d{4}-\d{2}-\d{2} {0,1}\d{0,2}:{0,1}\d{0,2}:
 const fieldFirstObjectIdPredicateRegex =
   /(properties|attributes)->`OBJECTID` (=|<|>|<=|>=) ([0-9]+)/g;
 
-const objectidInPredicateRegex = /(properties|attributes)->`OBJECTID` (IN) \((.+)\)/g;
+const objectidInPredicateRegex = /(properties|attributes)->`OBJECTID` (IN) \(([0-9,\s]+)\)/g;
 
 // RegExp for value-first predicate, e.g "1234 = properties->`OBJECTID`""
 const valueFirstObjectIdPredicateRegex =