-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix node memory collection #1392
koordlet: fix node memory collection #1392
Conversation
7fb1012
to
bb3c525
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
- Coverage 64.50% 64.49% -0.02%
==========================================
Files 330 331 +1
Lines 33905 33990 +85
==========================================
+ Hits 21872 21921 +49
- Misses 10427 10460 +33
- Partials 1606 1609 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bb3c525
to
99a69d6
Compare
99a69d6
to
07c7be8
Compare
07c7be8
to
4704ce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
4704ce2
to
731e45e
Compare
731e45e
to
f682a03
Compare
Signed-off-by: saintube <[email protected]>
f682a03
to
bcad6b8
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Fixed the bug in koordlet's node resource collector (introduced in #1316).
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test