-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: remove dependencies of sqlite3 #1484
koordlet: remove dependencies of sqlite3 #1484
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 64.13% 64.08% -0.06%
==========================================
Files 342 339 -3
Lines 35183 34991 -192
==========================================
- Hits 22566 22424 -142
+ Misses 10954 10911 -43
+ Partials 1663 1656 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I'll leave the lgtm to others.
hi, please change the file path in mock_gen.sh to |
Signed-off-by: 黄金 <[email protected]>
2c0ccfd
to
4f8cf2c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
replace sqlite with tsdb, remove dependencies of sqlite3, clean deprecated interfaces and structs.
Ⅱ. Does this pull request fix one issue?
fixes #1483
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test