Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: remove dependencies of sqlite3 #1484

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

LambdaHJ
Copy link
Contributor

Ⅰ. Describe what this PR does

replace sqlite with tsdb, remove dependencies of sqlite3, clean deprecated interfaces and structs.

Ⅱ. Does this pull request fix one issue?

fixes #1483

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (324d607) 64.13% compared to head (4f8cf2c) 64.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
- Coverage   64.13%   64.08%   -0.06%     
==========================================
  Files         342      339       -3     
  Lines       35183    34991     -192     
==========================================
- Hits        22566    22424     -142     
+ Misses      10954    10911      -43     
+ Partials     1663     1656       -7     
Flag Coverage Δ
unittests 64.08% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metriccache/metric_cache.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I'll leave the lgtm to others.

@zwzhang0107
Copy link
Contributor

hi, please change the file path in mock_gen.sh to pkg/koordlet/statesinformer/impl/states_informer.go

@LambdaHJ LambdaHJ force-pushed the remove-sqlite-dep branch from 2c0ccfd to 4f8cf2c Compare July 24, 2023 03:36
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e9383eb into koordinator-sh:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal]clear code dependencies of sqlite3.
4 participants