Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support core sched cookie management #1722

Conversation

saintube
Copy link
Member

@saintube saintube commented Oct 25, 2023

Ⅰ. Describe what this PR does

koordlet: support core scheduling cookie management of containers.

  1. apis: Add pod-level API apis: add core sched apis #1720.
  2. koordlet/utils: Add core sched basic operations via prctl (Get/Create/ShareTo/ShareFrom). Add enhanced operations like Assign/Clear (LockOSThread required).
  3. koordlet/runtimehooks: Add the plugin CoreSched to manage containers' cookies.

Ⅱ. Does this pull request fix one issue?

Part of #1728.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 359 lines in your changes are missing coverage. Please review.

Comparison is base (d51d900) 66.51% compared to head (f85564d) 66.88%.

Files Patch % Lines
pkg/koordlet/util/system/core_sched.go 61.97% 62 Missing and 19 partials ⚠️
...kg/koordlet/runtimehooks/hooks/coresched/helper.go 82.54% 36 Missing and 12 partials ⚠️
...oordlet/runtimehooks/hooks/coresched/core_sched.go 87.92% 29 Missing and 10 partials ⚠️
pkg/koordlet/util/system/core_sched_linux.go 66.66% 37 Missing and 2 partials ⚠️
pkg/koordlet/metrics/core_sched.go 27.02% 26 Missing and 1 partial ⚠️
pkg/koordlet/resourceexecutor/reader.go 49.05% 23 Missing and 4 partials ⚠️
pkg/koordlet/runtimehooks/hooks/coresched/rule.go 89.57% 11 Missing and 6 partials ⚠️
pkg/util/metrics/expire_metric.go 77.41% 9 Missing and 5 partials ⚠️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 13.33% 13 Missing ⚠️
.../koordlet/runtimehooks/protocol/kubeqos_context.go 0.00% 12 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
+ Coverage   66.51%   66.88%   +0.36%     
==========================================
  Files         395      403       +8     
  Lines       43841    45327    +1486     
==========================================
+ Hits        29163    30318    +1155     
- Misses      12518    12792     +274     
- Partials     2160     2217      +57     
Flag Coverage Δ
unittests 66.88% <77.19%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the koordlet-support-core-sched-management branch 10 times, most recently from b917a00 to 628d1f8 Compare November 3, 2023 03:47
@saintube saintube changed the title [WIP] koordlet: support core sched management koordlet: support core sched management Nov 3, 2023
@saintube saintube force-pushed the koordlet-support-core-sched-management branch 6 times, most recently from 78cdf62 to 2be4611 Compare November 7, 2023 07:16
@saintube saintube force-pushed the koordlet-support-core-sched-management branch 5 times, most recently from 4341b59 to 319e6e6 Compare November 9, 2023 08:52
apis/slo/v1alpha1/nodeslo_types.go Outdated Show resolved Hide resolved
apis/slo/v1alpha1/pod.go Outdated Show resolved Hide resolved
pkg/koordlet/runtimehooks/hooks/coresched/rule.go Outdated Show resolved Hide resolved
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ZiMengSheng
Copy link
Contributor

/milestone 1.5

@koordinator-bot
Copy link

@ZiMengSheng: The provided milestone is not valid for this repository. Milestones in this repository: [someday, v1.4, v1.5]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ZiMengSheng
Copy link
Contributor

/milestone v1.5

@koordinator-bot koordinator-bot bot added this to the v1.5 milestone Jan 2, 2024
@saintube saintube force-pushed the koordlet-support-core-sched-management branch from 0a8cdad to c448191 Compare January 3, 2024 09:54
@koordinator-bot koordinator-bot bot removed the lgtm label Jan 3, 2024
@saintube saintube force-pushed the koordlet-support-core-sched-management branch from c448191 to 237d69b Compare January 3, 2024 10:07
@saintube saintube force-pushed the koordlet-support-core-sched-management branch from 237d69b to f85564d Compare January 4, 2024 06:58
@hormes
Copy link
Member

hormes commented Jan 4, 2024

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e919946 into koordinator-sh:main Jan 5, 2024
20 checks passed
bowen-intel pushed a commit to kangclzjc/koordinator that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants