koord-descheduler: add migration object limiter for namespace #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songtao98
force-pushed
the
support_namespace_migration_limit
branch
2 times, most recently
from
37e3272 to
a9a9d87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
+ Coverage 67.90% 67.94% +0.03%
==========================================
Files 441 441
Lines 41551 41589 +38
==========================================
+ Hits 28217 28258 +41
+ Misses 10903 10898 -5
- Partials 2431 2433 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
songtao98
force-pushed
the
support_namespace_migration_limit
branch
from
a9a9d87 to
8142750
Compare
|
/hold |
songtao98
force-pushed
the
support_namespace_migration_limit
branch
from
8142750 to
0f4dfd8
Compare
songtao98
force-pushed
the
support_namespace_migration_limit
branch
from
0f4dfd8 to
cd139f3
Compare
|
/unhold |
songtao98
force-pushed
the
support_namespace_migration_limit
branch
from
cd139f3 to
f8c322b
Compare
Signed-off-by: songtao98 <[email protected]>
songtao98
force-pushed
the
support_namespace_migration_limit
branch
from
f8c322b to
72f9108
Compare
|
/lgtm |
hormes
approved these changes
Jul 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR add a new type of migration object limiter for namespace.
To implement this, the arbitrator of MigrationController traverses all objectLimiters and judge a pod through limiters enabled one by one.
When a pod is judged by Workload limiter, first try to get its
ownerReference, if there is noownerReferenceof this pod, just skip it.When a pod is judged by Namespace limiter, judge it by number of migrated pods in this namespace.
The similar logic is implemented in
trackEvictedPodfunction, too.Ⅱ. Does this pull request fix one issue?
fixes #2051
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test