Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: pod resources proxy #2300

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ferris-cx
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@ferris-cx ferris-cx force-pushed the monitor-for-dcgm branch 2 times, most recently from 08677ee to a754d1b Compare December 20, 2024 13:37
@ZiMengSheng ZiMengSheng force-pushed the monitor-for-dcgm branch 3 times, most recently from 003a798 to 890b3e5 Compare February 10, 2025 11:26
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 19.01840% with 132 lines in your changes missing coverage. Please review.

Project coverage is 65.93%. Comparing base (96ff411) to head (7a061d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ordlet/statesinformer/impl/states_pod_resources.go 24.36% 89 Missing and 1 partial ⚠️
...g/koordlet/util/kubelet/kubelet_resource_client.go 0.00% 40 Missing ⚠️
pkg/koordlet/util/system/config.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   66.05%   65.93%   -0.12%     
==========================================
  Files         464      466       +2     
  Lines       54651    54811     +160     
==========================================
+ Hits        36097    36137      +40     
- Misses      15946    16067     +121     
+ Partials     2608     2607       -1     
Flag Coverage Δ
unittests 65.93% <19.01%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng ZiMengSheng requested a review from saintube February 10, 2025 12:40
@ZiMengSheng ZiMengSheng force-pushed the monitor-for-dcgm branch 2 times, most recently from c93c2fe to b447b28 Compare February 11, 2025 02:11
.licenseignore Outdated Show resolved Hide resolved
pkg/features/koordlet_features.go Outdated Show resolved Hide resolved
pkg/koordlet/statesinformer/impl/config.go Outdated Show resolved Hide resolved
pkg/koordlet/statesinformer/impl/states_pod_resources.go Outdated Show resolved Hide resolved
pkg/koordlet/statesinformer/impl/states_pod_resources.go Outdated Show resolved Hide resolved
@saintube saintube changed the title monitor for dcgm koordlet: monitor for dcgm Feb 11, 2025
@ZiMengSheng ZiMengSheng force-pushed the monitor-for-dcgm branch 3 times, most recently from dbfa6f5 to 3cf11a9 Compare February 11, 2025 04:12
pkg/koordlet/statesinformer/impl/config.go Outdated Show resolved Hide resolved
.licenseignore Outdated Show resolved Hide resolved
Signed-off-by: wangjianyu.wjy <[email protected]>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube added the lgtm label Feb 11, 2025
@ZiMengSheng ZiMengSheng changed the title koordlet: monitor for dcgm koordlet: pod resources proxy Feb 11, 2025
@koordinator-bot koordinator-bot bot merged commit 04292dc into koordinator-sh:main Feb 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants