Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest #12

Merged
merged 10 commits into from
Dec 20, 2019
Merged

Unittest #12

merged 10 commits into from
Dec 20, 2019

Conversation

Seungbongjung
Copy link
Collaborator

@Seungbongjung Seungbongjung commented Dec 12, 2019

  • LinearAlgebra.mul!(C::MPIMatrix{T,AT}, A::Transpose{T,ATT} where ATT <: AbstractMatrix{T}, B::MPIMatrix{T,AT}) where {T,AT}
  • LinearAlgebra.mul!(C::Transpose{T,MPIMatrix{T,AT}}, A::Transpose{T,MPIMatrix{T,AT}}, B::AbstractMatrix{T}) where {T,AT}
  • LinearAlgebra.mul!(C::AbstractVector{T}, A::Transpose{T, MPIMatrix{T,AT}}, B::AbstractVector{T}) where {T,AT}
  • LinearAlgebra.dot(A::MPIArray, B::MPIArray)
  • opnorm(A::MPIMatrix, p::Real; method::String="power", tol=1e-6, maxiter=1000, seed=777, verbose=false)

Fixes #13.

Copy link
Owner

@kose-y kose-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 내용을 참고하기 바랍니다.

이제 Travis CI의 세팅이 끝났습니다: 앞으로는 Travis build가 실패하면 코드에 뭔가 문제가 있다는 의미입니다.

@codecov

This comment has been minimized.

@kose-y kose-y self-requested a review December 19, 2019 07:52
Copy link
Owner

@kose-y kose-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했습니다. mul!에 있던 오류와 몇 가지 자잘한 부분들을 고쳤고, CI test만 통과하면 바로 merge하겠습니다.

@kose-y kose-y merged commit e962d36 into master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinearAlgebra.mul!에서
2 participants