Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: support for [RoutingPolicyRule] and its most common parameters #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

am-beta
Copy link

@am-beta am-beta commented Feb 6, 2025

I hope the naming of variables I chose is consistant with the naming chosen so far.

@am-beta am-beta force-pushed the feature/routing-policy-rule branch from 4c01d7d to 2570bbd Compare February 6, 2025 13:56
@kpfleming
Copy link
Owner

It is fine! Generally Ansible uses snake_case and systemd uses CamelCase so that's what I've been doing to translate between them.

@kpfleming
Copy link
Owner

You'll also need to add an entry in workflow-support/templates/network-vars.yml.j2 since this adds a new block of arguments.

Also, please add an entry in the Unreleased section of CHANGELOG.md and I'll finalize/merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants