Skip to content

Commit

Permalink
Merge pull request #11 from amakhnach/feature/support_python3
Browse files Browse the repository at this point in the history
NEW: Added decoding of repo_dir for get_git_repo_dir.
  • Loading branch information
sergray committed May 19, 2016
2 parents 3298a11 + bd30e00 commit af1678f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
9 changes: 9 additions & 0 deletions pkgversion/pkgversion.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# -*- coding: utf-8 -*-
import locale
import os
import pprint
import re
Expand Down Expand Up @@ -27,6 +28,14 @@ def get_git_repo_dir():
repo_dir = repo_dir.strip()
if not repo_dir:
repo_dir = None

if repo_dir and not isinstance(repo_dir, str):

encoding = locale.getpreferredencoding()

if encoding:
return repo_dir.decode(encoding)

return repo_dir


Expand Down
6 changes: 3 additions & 3 deletions tests/test_pkgversion.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ def test_pep440_version(self):
def test_list_requirements(self):
actual = list_requirements(requirements_file)
expected = [
'unversioned', 'pinned-version==1.0',
'ranged-version<=2,>=1.0', 'url', 'unversioned-url',
'unversioned', 'pinned_version==1.0',
'ranged_version<=2,>=1.0', 'url', 'unversioned_url',
'editable'
]
assert actual == expected

def test_get_git_repo_dir(self):
assert os.path.isdir(get_git_repo_dir())
assert os.path.isdir(os.path.join(get_git_repo_dir(), b'.git'))
assert os.path.isdir(os.path.join(get_git_repo_dir(), '.git'))

def test_get_git_repo_dir_invalid(self):
pwd = os.getcwd()
Expand Down

0 comments on commit af1678f

Please sign in to comment.